Queen Elsa, from Frozen, had a difficult time growing up but maintained positive personality traits despite the time she spent having to cut herself off from the world. Her powers, though distressing to her, are beautiful, and show that she is a force she is to be reckoned with. She is diplomatic and tries to help her subjects with their problems.
On the other hand, Elsa's fear of herself led to several other problems, like her anxiety and overprotectiveness. Elsa constantly fears rejection from others and has always wanted to find the source of her powers. Maybe that's why it makes sense that she isn't destined to stay Arendelle's queen for long, despite all the good she did for the country.
Best: Powerful
Elsa's magic manifested itself soon after her birth, and it only grew as she did. At the age of eight, she struck her sister in the head with her powers, causing Anna to require magical intervention before recovering. Elsa is also the only human in the Frozen films to have magic. On the bright side, it's one of her great joys. In the first film, she's clearly at her happiest when performing magic. It allows her to pursue her goals in both films, which is another reason why it is one of her best traits.
Worst: Overprotective
As the elder of the two sisters, Elsa can be quite overprotective. When they were children, she caused a major accident, which led to Elsa protecting her sister by staying away from her. Despite barely speaking to her sister before her coronation, Elsa felt the need to try to dictate her marriage choices. Elsa's overprotective nature mostly just frustrates Anna, and though it occasionally helps, it's mostly a hindrance. Ultimately, both sisters are at their best when they aren't living together, able to constantly comment on each other's choices.
Best: Diplomatic
Elsa is one of the few Disney Queens who even touches on anything resembling policy. She's diplomatic with the Duke of Weselton, convincing him to dance with Anna instead of herself, and later refusing his trade agreements. It shows that she has the training and skill necessary to be a Queen, and will succeed at whatever she sets her mind to. She can also let people down gently, and convince them to avoid going to war with her, which is definitely a positive.
Worst: Overcompensates
After Anna's accident, Elsa overcompensates by trying to hide her powers. Instead, this just makes her afraid of them - and herself. Continuing down this road even turns her ice palace sanctuary into something dark and threatening later in the film.
Elsa doesn't know where to stop, because she was never taught. Luckily, being with friends and family helps to stave off those thoughts, and teaches her how to control her powers.
Best: Kind
During the harvest festival at the beginning of Frozen 2, Elsa is shown creating objects made of ice for the children. Upon close viewing, one of these is shown to be a sextant, a navigational tool. Elsa is therefore shown as willing to think outside the box and take the time to come up with something the children will actually appreciate. This is another mark of a good ruler: pleasing the people.
Worst: Hides From Problems
Due to the mantra her father pushed on her, Elsa constantly tries to push down her emotions and thoughts on her problems. This, first of all, isn't healthy, and secondly, doesn't work out very well for Elsa. She nearly freezes the sacred instruments of her coronation and eventually sets off a winter when her anger gets the better of her, crying out an iconic "Enough!" to Anna. It's only when she discovers that her emotions are connected to her magic that everything starts to even out and get better. Having Anna as a sister, someone who runs towards problems rather than away, probably helps too.
Best: Hardworking
Elsa put in the work to open Arendelle's gates diplomatically for her coronation, and she seems to be getting on well with most of the dignitaries during the party, unlike Anna, proving herself better here. Even the coronation itself is a lot of stress for her, but she goes through it successfully. She clearly cares for the people and works hard to make sure everyone has a good time. She runs away to avoid hurting others, even when the only one she's hurting is herself.
Worst: Puts Others Above Herself
During the confrontation with Anna in her ice palace, Elsa makes it clear that she puts her sister's happiness above her own. Her isolated life has made it so that she doesn't want to come into with anyone, and her training to be queen has asked her to put her civilians before herself.
This isn't so positive with Elsa because, combined with her anxiety and depression, this trait turns her into a person who hides away - and plans to do that for the rest of her life. Luckily, others intervene.
Best: Refined
Elsa's refined nature is a contrast to Anna's clumsiness, showing Elsa to be the best princess in that respect. On the other hand, Elsa has internal problems, while Anna is bubbly and loves people outwardly. Elsa's demeanor easily gets her through the coronation and most of the party, but inwardly it's difficult to tell if she actually enjoys herself. When just with her sister she loosens up, and things become easier. Her refined nature continues when Anna finds her in her ice palace, and she even goes so far as to remark on the change.
Worst: Afraid of Herself
In the first film, Elsa's isolation and mantra about her powers have caused her to fear herself. She's terrified of hurting anyone else, and that causes her to shun all physical with anyone else. She's afraid of what she can do. Anna chases after her, trying to convince her to come home, and it's only after Anna's sacrifice that Elsa realizes the actual key to controlling her powers. With that, the fear recedes, and it's clear that, three years later, Elsa isn't scared of herself anymore.